It is really enjoyable and exciting to contribute to SMB.

Click here to see my emails on the SMB mailing list.

Click here to see my upstream Linux kernel commit history on kernel.org （The page may take a moment to load, you can directly check the patch links listed below）

Click here to see my other kernel module patches.

1 2026

• Review: 99cd0a6eeb6c smb/client: do not account EOF extension as allocation

• Review: 2a4b3d2db5c6 smb/client: preserve errors from smb2_set_sparse()

• Review: 898d280f4e4d smb/client: name the default fallocate mode

• Review: 954d196bebb2 ksmbd: validate NTLMv2 response before updating session key

• 37ee476071bc smb/server: fix debug log endianness in smb2_cancel()

• f4d556008fd4 smb/server: fix incorrect file size in get_file_compression_info()

• 5560f971645c smb/server: get compression format in get_file_compression_info()

• 7eeb7b6772f0 smb/server: implement FSCTL_SET_COMPRESSION ioctl handler

• c91f4543ddec smb/server: implement FSCTL_GET_COMPRESSION ioctl handler

• e48b687221f4 smb/server: get compression file attribute on open

• 9d357903ec9b smb: move compression definitions into common/fscc.h

• 31c09ce67a81 smb: remove duplicate server/smbfsctl.h

• Review: 3ecad5de621e smb/client: allow FS_IOC_SETFLAGS to clear compression

• Review: 5693347de107 smb/client: use writable handle for FS_IOC_SETFLAGS compression

• Review: 7acbaa16b99e smb/client: always return a value for FS_IOC_GETFLAGS

• Review: af25ab681ea0 smb/client: update i_blocks after contiguous writes

• 4ec9c8e023c7 smb/server: promote S_DEL_ON_CLS to S_DEL_PENDING when close

• Review: 7d9a7f1f96cd smb/client: fix possible infinite loop and oob read in symlink_data()

• [cifs-utils] smbinfo: parse action and filename from change notifications

• [cifs-utils] smbinfo: update notify subcommand

• [cifs-utils] smbinfo: add filecompressioninfo subcommand

• [cifs-utils] smbinfo: add notify subcommand

• [cifs-utils] cifs.upcall: fix calloc() argument order in main()

• Review: [cifs-utils] Decimated subseconds in smbinfo filebasicinfo timestamp output

• [PATCH v4 0/1] smb/client: fix out-of-bounds read

  • Review: 8d09328dfda0 smb/client: fix out-of-bounds read in smb2_compound_op()
  • Review: d62b8d236fab smb/client: fix out-of-bounds read in symlink_data()

• Review: 235e32320a47 ksmbd: fix use-after-free in __ksmbd_close_fd() via durable scavenger

• [PATCH v5 0/7] smb: fix some bugs, move duplicate definitions into common header file, part 2

  • Review: 95e1d378ce30 smb: move filesystem_vol_info into common/fscc.h
  • Review: 31884d4bc981 smb: move file_basic_info into common/fscc.h
  • Review: a5e581093b1d smb: move some definitions from common/smb2pdu.h into common/fscc.h

• Review: bc1a64d23641 smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

• Review: 59ea368431dd smb/client: move smb2maperror declarations to smb2proto.h

• [PATCH v3 00/13] smb: improve search speed of SMB1 maperror

  • Review: 85274a3bd40f smb/client: introduce KUnit tests to check DOS/SRV err mapping search
  • Review: 8c028dd086ad smb/client: check if SMB1 DOS/SRV error mapping arrays are sorted
  • Review: 95e6b7340957 smb/client: use binary search for SMB1 DOS/SRV error mapping
  • Review: 58ac796bb3c0 smb/client: autogenerate SMB1 DOS/SRV to POSIX error mapping
  • Review: cd4e653a2f75 smb/client: annotate smberr.h with POSIX error codes
  • Review: 669c3eedaefa smb/client: move ERRnetlogonNotStarted to DOS error class
  • Review: e3ac6352a84d smb/client: introduce KUnit test to check ntstatus_to_dos_map search
  • Review: 010ad1e895db smb/client: check if ntstatus_to_dos_map is sorted
  • Review: 3c6c23ed9424 smb/client: use binary search for NT status to DOS mapping
  • Review: 772d5920c3d4 smb/client: refactor ntstatus_to_dos() to return mapping entry
  • Review: c825f6b7432a smb/client: replace nt_errs with ntstatus_to_dos_map
  • Review: 415c5b8c9a41 smb/client: autogenerate SMB1 NT status to DOS error mapping
  • Review: 378f75b7d6ea smb/client: annotate nterr.h with DOS error codes

• Review: 53cf44fa7271 smb/client: avoid null-ptr-deref when tests fail in test_cmp_map()

• Review: 34420cb92dbb smb/client: ensure smb2_mapping_table rebuild on cmd changes (Author: Huiwen He hehuiwen@kylinos.cn)

• Review: 309b44ed6844 ksmbd: fix memory leaks and NULL deref in smb2_lock() (Author: Werner Kasselman werner@verivus.com)

  • Review: Re: [PATCH] ksmbd: fix memory leaks and NULL deref in smb2_lock()
  • Review: Re: [PATCH] ksmbd: fix memory leaks and NULL deref in smb2_lock()
  • Review: Re: [PATCH v2] ksmbd: fix memory leaks and NULL deref in smb2_lock()

• Review: 48623ec358c1 ksmbd: fix use-after-free and NULL deref in smb_grant_oplock() (Author: Werner Kasselman werner@verivus.com)

  • Review: Re: [PATCH] ksmbd: fix use-after-free and NULL deref in smb_grant_oplock()
  • Review: Re: [PATCH] ksmbd: fix use-after-free and NULL deref in smb_grant_oplock()
  • Review: Re: [PATCH v3] ksmbd: fix use-after-free and NULL deref in smb_grant_oplock()
  • Review: Re: [PATCH] ksmbd: fix use-after-free and NULL deref in smb_grant_oplock()

• Review: 40e75e42f49c smb: client: fix open handle lookup in cifs_open() (Author: Paulo Alcantara pc@manguebit.org)

• Review: 88d37abb366b smb/client: only export symbol for ‘smb2maperror-test’ module (Author: Ye Bin yebin10@huawei.com)

• Review: Re: [PATCH v4 5/5] smb: introduce struct file_posix_info

• Review: Re: [PATCH v4 5/5] smb: introduce struct file_posix_info

• Review: Re: [PATCH v4 5/5] smb: introduce struct file_posix_info

• Review: c15e7c62feb3 smb/server: Fix another refcount leak in smb2_open() (Author: Guenter Roeck linux@roeck-us.net)

  • Review: Re: [PATCH] smb/server: Fix another refcount leak in smb2_open()
  • Review: Re: [PATCH v2 1/1] smb/server: fix refcount leak in smb2_open()
  • Review: Re: [PATCH v2 1/1] smb/server: fix refcount leak in smb2_open()

• [PATCH v5 0/7] smb: fix some bugs, move duplicate definitions into common header file, part 2 (Author: ZhangGuoDong zhangguodong@kylinos.cn)

  • Review: 8098179dc981 smb/client: remove unused SMB311_posix_query_info()
  • Review: 9621b996e4db smb/client: fix buffer size for smb311_posix_qinfo in SMB311_posix_query_info()
  • Review: 12c43a062acb smb/client: fix buffer size for smb311_posix_qinfo in smb2_compound_op()
  • Review: 6f0402539b7d smb: update some doc references

• [PATCH] smb/client: make SMB2 maperror KUnit tests a separate module

  • 7d0bf050a587 smb/client: make SMB2 maperror KUnit tests a separate module

• [PATCH 0/7] smb/client: update SMB1 maperror, part 2

  • 3774289f525c smb/client: move NT_STATUS_MORE_ENTRIES
  • 617a5d2473dc smb/client: rename to NT_ERROR_INVALID_DATATYPE
  • fa34d0a57033 smb/client: rename to NT_STATUS_SOME_NOT_MAPPED
  • 4da735c48a27 smb/client: map NT_STATUS_PRIVILEGE_NOT_HELD
  • 3e5f08342860 smb/client: map NT_STATUS_MORE_PROCESSING_REQUIRED
  • e4424687fc6d smb/client: map NT_STATUS_BUFFER_OVERFLOW
  • ba39063ca3ee smb/client: map NT_STATUS_NOTIFY_ENUM_DIR

• [PATCH 00/17] smb/client: update SMB1 maperror (Author: Huiwen He hehuiwen@kylinos.cn)

  • Review: fbcdc61e7846 smb/client: remove useless comment in mapping_table_ERRSRV
  • Review: be9fc9033a0a smb/client: remove some literal NT error codes from ntstatus_to_dos_map
  • Review: 199e7a1a2ed9 smb/client: add NT_STATUS_VOLUME_NOT_UPGRADED
  • Review: 0bf7e53fec61 smb/client: add NT_STATUS_NO_USER_KEYS
  • Review: ded739a08228 smb/client: add NT_STATUS_WRONG_EFS
  • Review: 3988b5675296 smb/client: add NT_STATUS_NO_EFS
  • Review: 2ef4f6b46f3c smb/client: add NT_STATUS_NO_RECOVERY_POLICY
  • Review: 47b84c745ba0 smb/client: add NT_STATUS_RANGE_NOT_FOUND
  • Review: fbf88e79c53e smb/client: add NT_STATUS_DECRYPTION_FAILED
  • Review: 2ed0cdab5fcc smb/client: add NT_STATUS_ENCRYPTION_FAILED
  • Review: 096be7202493 smb/client: add NT_STATUS_DIRECTORY_IS_A_REPARSE_POINT
  • Review: 7982ddb7af9b smb/client: add NT_STATUS_VOLUME_DISMOUNTED
  • Review: 563318fa6dcc smb/client: add NT_STATUS_BIOS_FAILED_TO_CONNECT_INTERRUPT
  • Review: 29aaf48e24b7 smb/client: add NT_STATUS_VARIABLE_NOT_FOUND
  • Review: ac635d68bac8 smb/client: rename ERRinvlevel to ERRunknownlevel
  • Review: cd55c6e31189 smb/client: add NT_STATUS_OS2_INVALID_LEVEL
  • Review: b0a22915942f smb/client: map NT_STATUS_INVALID_INFO_CLASS to ERRbadpipe

• [PATCH v9 0/1] smb: improve search speed of SMB2 maperror

  • Review: 10dfb0738a9d cifs: Label SMB2 statuses with errors (Author: David Howells dhowells@redhat.com)
    • Review: Re: [PATCH 1/2] cifs: Label SMB2 statuses with errors
    • Review: Re: [PATCH 1/2] cifs: Label SMB2 statuses with errors
  • Review: c527e13a7a66 cifs: Autogenerate SMB2 error mapping table (Author: David Howells dhowells@redhat.com)
    • Review: Re: [PATCH 2/2] cifs: Autogenerate SMB2 error mapping table
  • 480afcb19b61 smb/client: introduce KUnit test to check search result of smb2_error_map_table
  • 75563adbb91d smb/client: use bsearch() to find target in smb2_error_map_table
  • 453382f15b0e smb/client: check whether smb2_error_map_table is sorted in ascending order

• Review: ebbbc4bfad4c smb: client: fix potential UAF and double free in smb2_open_file() (Author: Paulo Alcantara pc@manguebit.org)

  • Review: Re: [PATCH] smb: client: fix potential UAF and double free it smb2_open_file()
  • Review: Re: [PATCH] smb: client: fix potential UAF and double free it smb2_open_file()

• [PATCH v3 0/1] smb/client: fix memory leaks

  • 67b3da8d3051 smb/client: fix memory leak in SendReceive()
  • e3a43633023e smb/client: fix memory leak in smb2_open_file()

2 2025

• Review: fa2fd0b10f66 smb: client: fix UBSAN array-index-out-of-bounds in smb2_copychunk_range (Author: Henrique Carvalho henrique.carvalho@suse.com)

  • Review: Re: generic/013 failure to Samba
  • Review: Re: generic/013 failure to Samba

• [PATCH v2 0/1] smb/server: fix some refcount leaks

  • f416c556997a smb/server: fix refcount leak in smb2_open()
  • 3296c3012a9d smb/server: fix refcount leak in parse_durable_handle_context()
  • Review: xfstests failed test cases
  • Review: Re: xfstests failed test cases
  • Review: Re: xfstests failed test cases

• [PATCH] smb/server: call ksmbd_session_rpc_close() on error path in create_smb2_pipe()

  • 7c28f8eef5ac smb/server: call ksmbd_session_rpc_close() on error path in create_smb2_pipe()

• Review: cb6d5aa9c0f1 cifs: Fix memory and information leak in smb3_reconfigure() (Author: Zilin Guan zilin@seu.edu.cn)

• [PATCH v4 0/2] smb/server: fix minimum PDU size

  • 4c7d8eb9a79a smb/server: fix minimum SMB2 PDU size
  • 3b9c30eb8f5a smb/server: fix minimum SMB1 PDU size

• Review: 0a70cac78967 ksmbd: Fix to handle removal of rfc1002 header from smb_hdr (Author: David Howells dhowells@redhat.com)

  • Review: Re: [PATCH] ksmbd: Fix to handle removal of rfc1002 header from smb_hdr

• [PATCH v2 0/7] smb: move duplicate definitions into common header file, part 2

  • 94d5b8dbc5d9 smb: move some SMB1 definitions into common/smb1pdu.h
  • 2b6abb893e71 smb: move File Attributes definitions into common/fscc.h
  • c97503321ed3 smb: update struct duplicate_extents_to_file_ex
  • 2e0d224d8988 smb/server: add comment to FileSystemName of FileFsAttributeInformation
  • ab0347e67dac smb/client: remove DeviceType Flags and Device Characteristics definitions
  • 08c2a7d2bae9 smb: move file_notify_information to common/fscc.h
  • 6539e18517b6 smb: move SMB2 Notify Action Flags into common/smb2pdu.h
  • 9ec7629b430a smb: move notify completion filter flags into common/smb2pdu.h
  • bcdd6cfaf2ec smb: add documentation references for smb2 change notify definitions

• [PATCH 00/30] smb: improve search speed of SMB1 maperror

  • a71a4aab4834 smb/client: add parentheses to NT error code definitions containing bitwise OR operator
  • a9adafd40165 smb/client: add 4 NT error code definitions
  • 98def4eb0244 smb/server: remove unused nterr.h
  • 9f99caa8950a smb/client: fix NT_STATUS_UNABLE_TO_FREE_VM value
  • b2b50fca34da smb/client: fix NT_STATUS_DEVICE_DOOR_OPEN value
  • a1237c203f17 smb/client: fix NT_STATUS_NO_DATA_DETECTED value

• [PATCH v9 0/1] smb: improve search speed of SMB2 maperror

  • d8f52650b24d smb/client: update some SMB2 status strings
  • d159702c9492 smb/client: add two elements to smb2_error_map_table array
  • 523ecd976632 smb: rename to STATUS_SMB_NO_PREAUTH_INTEGRITY_HASH_OVERLAP
  • bf80d1517dc8 smb/client: remove unused elements from smb2_error_map_table array
  • 6c1eb31ecb97 smb/client: reduce loop count in map_smb2_to_linux_error() by half
  • 01ab0d1640e3 smb/server: rename include guard in smb_common.h

• [PATCH v9 0/1] smb: move duplicate definitions to common header file

  • c4a2a49f7df4 smb: move FILE_SYSTEM_ATTRIBUTE_INFO to common/fscc.h
  • 5003ad718af7 smb: move create_durable_reconn to common/smb2pdu.h
  • e7e60e8bfcc5 smb: fix some warnings reported by scripts/checkpatch.pl
  • 95e8c1bfa56e smb: do some cleanups
  • 464b913993a1 smb: move FILE_SYSTEM_SIZE_INFO to common/fscc.h
  • d7edd3892d97 smb: move some duplicate struct definitions to common/fscc.h
  • 84d8d4cf8873 smb: move list of FileSystemAttributes to common/fscc.h
  • d8ac9879182a smb: move SMB_NEGOTIATE_REQ to common/smb2pdu.h
  • 1172d8598499 smb: move some duplicate definitions to common/smb2pdu.h
  • 96721fd29226 smb: move create_durable_rsp_v2 to common/smb2pdu.h
  • 81a45de432c6 smb: move create_durable_handle_reconnect_v2 to common/smb2pdu.h
  • 833a75fc9ecc smb: move create_durable_req_v2 to common/smb2pdu.h
  • 884a1d4e9c09 smb: move MAX_CIFS_SMALL_BUFFER_SIZE to common/smbglob.h
  • 4a7f96078032 smb/client: fix CAP_BULK_TRANSFER value
  • 9c98f5eec877 smb: move resume_key_ioctl_rsp to common/smb2pdu.h
  • cc26f593dc19 smb: move copychunk definitions to common/smb2pdu.h
  • 7844d50ca239 smb: move smb_sockaddr_in and smb_sockaddr_in6 to common/smb2pdu.h
  • cd311445d9f5 smb: move SMB1_PROTO_NUMBER to common/smbglob.h
  • 36c31540cf52 smb: move get_rfc1002_len() to common/smbglob.h
  • 34cf191bb6a3 smb: move smb_version_values to common/smbglob.h
  • 94b955167e3b smb: rename common/cifsglob.h to common/smbglob.h
  • d877470b5991 smb: move some duplicate definitions to common/cifsglob.h
  • CVE-2025-40285: 379510a815cb smb/server: fix possible refcount leak in smb2_sess_setup()
  • CVE-2025-40286: 6fced056d2cc smb/server: fix possible memory leak in smb2_read()

• [PATCH v2 0/6] smb/server: fix return values of smb2_0_server_cmds proc

  • 7d9f51d36b6c smb/server: update some misguided comment of smb2_0_server_cmds proc
  • a3c4445fdbbb smb/server: fix return value of smb2_oplock_break()
  • 269df046c1e1 smb/server: fix return value of smb2_ioctl()
  • dafe22bc676d smb/server: fix return value of smb2_query_dir()
  • d1a30b9ddc3d smb/server: fix return value of smb2_notify()
  • c5b462e35373 smb/server: fix return value of smb2_read()

3 2024

• [PATCH v2 00/12] smb: fix some bugs, move duplicate definitions to common header file, and some small cleanups
  • e2fcd3fa0351 smb: add comment to STATUS_MCA_OCCURED
  • 78181a5504a4 smb: move SMB2 Status code to common header file
  • b51174da743b smb: move some duplicate definitions to common/smbacl.h
  • 09bedafc1e2c smb/client: rename cifs_ace to smb_ace
  • 251b93ae7380 smb/client: rename cifs_acl to smb_acl
  • 7f599d8fb3e0 smb/client: rename cifs_sid to smb_sid
  • 3651487607ae smb/client: rename cifs_ntsd to smb_ntsd
  • 5e51224d2afb smb/client: fix typo: GlobalMid_Sem -> GlobalMid_Lock
  • 2b7e0573a490 smb/server: update misguided comment of smb2_allocate_rsp_buf()
  • 0dd771b7d60b smb/server: remove useless assignment of ‘file_present’ in smb2_open()
  • CVE-2024-46742: 4e8771a3666c smb/server: fix potential null-ptr-deref of lease_ctx_info in smb2_open()（查看分析）
  • 2186a116538a smb/server: fix return value of smb2_open()（邮件列表）
• [PATCH] ksmbd: remove duplicate SMB2 Oplock levels definitions
  • ac5399d48616 ksmbd: remove duplicate SMB2 Oplock levels definitions

4 2023

• [PATCH] ksmbd: fix possible refcount leak in smb2_open()
  • CVE-2023-53061: 2624b445544f ksmbd: fix possible refcount leak in smb2_open()

5 2022

• 502487847743 cifs: fix missing unlock in cifs_file_copychunk_range()（邮件列表）
• 542228db2f28 cifs: fix use-after-free on the link name（邮件列表）
• 2b058acecf56 cifs: return the more nuanced writeback error on close()（邮件列表）